manifest: Do not wrongly ascribe target to rust-src and friends #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some components have no target (target="*") and as such when we install them, we should not ascribe a target to them. Before this, installing `--profile complete` would incorrectly show `rust-src` as not installed, despite being so. After this fix, anyone updating such a broken toolchain install must first `rustup component remove rust-src` and then reinstall it either before or after upgrading. Fixes: rust-lang#2081
|
When approximately that will be released? |
|
I don't currently have a timeline for 1.21 but maybe at or after Rustfest |
|
Sure, I'll be waiting for it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some components have no target (target="*") and as such when we
install them, we should not ascribe a target to them. Before this,
installing
--profile completewould incorrectly showrust-srcas not installed, despite being so.
After this fix, anyone updating such a broken toolchain install must
first
rustup component remove rust-srcand then reinstall it eitherbefore or after upgrading.
Fixes: #2081